Validate accessibility of members referenced in calculated member formulas#144
Closed
jjustaments wants to merge 2 commits intomasterfrom
Closed
Validate accessibility of members referenced in calculated member formulas#144jjustaments wants to merge 2 commits intomasterfrom
jjustaments wants to merge 2 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds validation to ensure that members referenced in calculated member formulas respect role-based access controls. It applies a patch to the Mondrian OLAP Java library that checks role access when evaluating members in sets, preventing unauthorized member aggregation.
Key changes:
- Adds role access validation in SetFunDef to filter out inaccessible members during evaluation
- Introduces comprehensive test coverage for calculated members with role restrictions
- Tests both .Children aggregation and explicit set aggregation scenarios
Owner
|
As discussed will not implement this as it adds additional overhead for all queries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mondrian patch: