Allow user to custom order of field in ConsoleWriter #170
+45
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r of output. If user didn't specify, then will use dictionary order. In some case, the system have specific requirement for the order of output field. But json is unordered in definition. So we need decode json and reorder. Add test accordingly.
|
👍 |
|
@TommyCpp is there any news? |
Author
I don’t think it’s gonna be merged. Haven’t heard from the author. |
rs
force-pushed
the
master
branch
2 times, most recently
from
a78256a to
f09463f
Compare
|
Nice; it would be great if there was a default implementation that ordered by the JSON/Dict keys as that would probably be the most common sort method. |
|
Any updates on this feature? This would be very helpful. :) |
Contributor
|
Just submitted PR #550. Should have checked for previous work first. :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As point out in #155. It would be nice to have some control on the order of the output field.
Add example on how to custom field's order.