-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix: Fix input.type check #1184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: d950907 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
8a3bbd3 to
24b2b59
Compare
|
Can you rebase the master branch so that the new changes can be reviewed faster? The current change seems to include all changes in #1170 |
As far as I can tell this is rebased onto current master? It just changes/fixes stuff that was added there. |
Ah I see. So sorry, I mistook these similar changes to 1170. I will review this pr tomorrow. |
YunFeng0817
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Could you please resolve the merge conflicts so that I can merge this pull request?
|
Hey @mydea could you fix the merge issues, then we can merge this branch into master? |
6b1ce69 to
e7cd099
Compare
Did it! |
0fea754 to
1f7661e
Compare
Actually I noticed that `el.type` returns `text` when type is not explicitly set, so this is slightly incorrect.
73f367a to
cc4649d
Compare
Actually I noticed that
el.typereturnstextwhen type is not explicitly set, so this is slightly incorrect.This was slightly incorrect in #1170