Skip to content

Conversation

@mydea
Copy link
Contributor

@mydea mydea commented Mar 20, 2023

Actually I noticed that el.type returns text when type is not explicitly set, so this is slightly incorrect.

This was slightly incorrect in #1170

@changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2023

🦋 Changeset detected

Latest commit: d950907

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
rrweb Patch
rrweb-snapshot Patch
rrdom Patch
rrdom-nodejs Patch
rrweb-player Patch
@rrweb/types Patch
@rrweb/web-extension Patch
rrvideo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mydea mydea force-pushed the fn/fix-password-type branch from 8a3bbd3 to 24b2b59 Compare March 20, 2023 16:09
@YunFeng0817
Copy link
Member

Can you rebase the master branch so that the new changes can be reviewed faster? The current change seems to include all changes in #1170

@mydea
Copy link
Contributor Author

mydea commented Mar 21, 2023

Can you rebase the master branch so that the new changes can be reviewed faster? The current change seems to include all changes in #1170

As far as I can tell this is rebased onto current master? It just changes/fixes stuff that was added there.

@YunFeng0817
Copy link
Member

Can you rebase the master branch so that the new changes can be reviewed faster? The current change seems to include all changes in #1170

As far as I can tell this is rebased onto current master? It just changes/fixes stuff that was added there.

Ah I see. So sorry, I mistook these similar changes to 1170. I will review this pr tomorrow.

Copy link
Member

@YunFeng0817 YunFeng0817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you please resolve the merge conflicts so that I can merge this pull request?

@Juice10
Copy link
Member

Juice10 commented Apr 7, 2023

Hey @mydea could you fix the merge issues, then we can merge this branch into master?

@mydea mydea force-pushed the fn/fix-password-type branch from 6b1ce69 to e7cd099 Compare April 7, 2023 10:32
@mydea
Copy link
Contributor Author

mydea commented Apr 7, 2023

Hey @mydea could you fix the merge issues, then we can merge this branch into master?

Did it!

@mydea mydea force-pushed the fn/fix-password-type branch from 0fea754 to 1f7661e Compare April 7, 2023 12:16
Actually I noticed that `el.type` returns `text` when type is not explicitly set, so this is slightly incorrect.
@mydea mydea force-pushed the fn/fix-password-type branch from 73f367a to cc4649d Compare April 7, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants