Use smart pointers instead of raw pointers #96
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This looks good, thanks for the PR. I had been meaning to add the de-constructor, but since we never de-allocated until the program ended I never put it at high priority. Using |
Member
|
I have started working on merging this. I have ended up switching over the shared_ptr to match how I original implemented everything. Feedback welcomed, but I am replacing the majority of all points in the database to this. After changing memcheck doesn't report any "definitely lost" memory losses, so that is a positive as compared to before. |
Member
|
Should be addressed in #117, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VioManagerleaked memory, because it would hold pointers that it does not deallocate when it is deallocated.VioManagerhold "smart pointers", so the memory will automatically be deallocated when theVioManagergets deleted (as opposed to writing a destructor and copy-constructor).VioManageruncopyable, but I believe that before this, copies ofVioManagerwere logically incorrect, because the old code would make shallow copies of the internal member pointers.TrackBaseneeds to have a virtual destructor to deallocate properly.