Skip to content

Conversation

@Jan200101
Copy link
Contributor

gpg may prompt for a password which will hold up any package from building

gpg may prompt for a password which will hold up any package from building
@Jan200101 Jan200101 requested a review from a team as a code owner March 17, 2025 10:19
@Jan200101 Jan200101 requested review from dmnks and removed request for a team March 17, 2025 10:19
@dmnks
Copy link
Contributor

dmnks commented Mar 21, 2025

We have this whack-a-mole situation in the git macros where we try to undo any problematic git settings a user may have on the system globally. This is not new by any means, and is pretty much what #3472 is about, too.

Instead, it would perhaps be better to start with a clean, well-defined git config for the purposes of %autopatch -S git, and only let the global config come into effect when using git manually from the build directory (when making additional patches or resolving conflicts).

That said, in the interim, this fix may suffice, of course. @pmatilai, @ffesti, any thoughts?

@pmatilai
Copy link
Member

Seems harmless enough to me 😅

@dmnks
Copy link
Contributor

dmnks commented Mar 21, 2025

Okay then, let's merge 👍

@dmnks dmnks merged commit 6cf15a3 into rpm-software-management:master Mar 21, 2025
1 check passed
@dmnks
Copy link
Contributor

dmnks commented Mar 21, 2025

@Jan200101 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants