Fix CountDown generic support #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ithinuel
force-pushed
the
fix-delay-support
branch
from
b48efd3 to
59e3229
Compare
jannic
approved these changes
Sep 1, 2023
Member
jannic
left a comment
jannic
left a comment
There was a problem hiding this comment.
Looks good. Didn't try it yet, but I'll do together with the hal-0.9 branch before merging it into main.
Member
|
It caused a clippy warning. I fixed it directly on the hal-0.9 branch: b38b344 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why I broke it like this when I migrated from embedded-time to fugit 🤷