Add ROSIDL enum support

[r7vme]

Signed-off-by: Roman Sokolkov [email protected]

Main PR ros2/rosidl#685

Related issue ros2/rosidl#260

[r7vme]

@audrow could you please take a look?

[ros-discourse]

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/need-reviewers-for-rosidl-related-change/26285/1

[audrow]

Here's CI to get us started:

• Linux
• Linux-aarch64
• Windows

[audrow]

Looks fine to me, but let's make sure than this and the related PR don't break things downstream.

[r7vme]

@audrow thanks for review, I fixed header names in this PR. I was able to reproduce the problem locally, seems I renamed Enums.idl to EnumsMessage.idl at some point. However, this job is still failing with

10:50:19 /tmp/ws/src/rosidl/rosidl_generator_c/test/test_interfaces.c:28:10: fatal error: rosidl_generator_c/idl/enums_message.h: No such file or directory
10:50:19    28 | #include "rosidl_generator_c/idl/enums_message.h"
10:50:19       |         

Locally I was able to compile successfully whole ros2 workspace with my forks.

[r7vme]

@audrow do you know may be some ROS working group , where I can present this feature and may be get some feedback?

[audrow]

@audrow do you know may be some ROS working group , where I can present this feature and may be get some feedback?

Maybe the Middleware Working Group? @wjwwood or @clalancette, any thoughts?
https://docs.ros.org/en/rolling/The-ROS2-Project/Governance.html#working-groups-wgs

[r7vme]

Thanks @audrow. Could you please rerun CI like you did here? #20 (comment)

[methylDragon]

• Linux
• Linux-aarch64
• Windows

[methylDragon]

I suspect the job failing is happening because this PR hasn't been merged yet. If CI comes up happy we can merge this and 🤞

[r7vme]

@methylDragon thanks, we discovered issue with ROS Services support and currently working on it. I'll ping you, folks, as soon as it will be ready.

[r7vme]

Closing as I have no plans to work on this in the near time (see more details here).