-
Notifications
You must be signed in to change notification settings - Fork 144
Add rosidl_auto_generate_inetrfaces function
#918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HansRobo
wants to merge
9
commits into
ros2:rolling
Choose a base branch
from
HansRobo:feature/rosidl_auto_generate_interfaces
base: rolling
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add rosidl_auto_generate_inetrfaces function
#918
HansRobo
wants to merge
9
commits into
ros2:rolling
from
HansRobo:feature/rosidl_auto_generate_interfaces
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt_cmake#600) Signed-off-by: Kotaro Yoshimoto <[email protected]>
…ILD_DEPENDS by ament_cmake_auto Signed-off-by: Kotaro Yoshimoto <[email protected]>
…nerate_interfaces Signed-off-by: Kotaro Yoshimoto <[email protected]>
…nerate_interfaces Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
…extras.cmake Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
ahcorde
reviewed
Nov 28, 2025
Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Kotaro Yoshimoto <[email protected]>
fujitatomoya
approved these changes
Dec 2, 2025
Contributor
fujitatomoya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Contributor
|
@HansRobo is this still draft? it seems ready for review? |
Author
|
Yes, it's ready for review! I checked building with GitHub Actions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull-request adds
rosidl_auto_generate_inetrfacesfunction to simplify boilerplate CMake in interface packages.rosidl_auto_generate_inetrfacesfunction was originally planned as theament_auto_generate_codefunction. However, when I implemented it in ament/ament_cmake#600, I was advised to move it torosidl_cmakebecauseament_cmake's dependency onrosidl_cmakewould create a circular dependency.Using
rosidl_auto_generate_inetrfacessimplifies CMake for interface packages as follows:before
after
Is this user-facing behavior change?
Did you use Generative AI?
I used Gemini 3.0 to review my code.
Additional Information