-
Notifications
You must be signed in to change notification settings - Fork 144
Documentation: action, message, service typesupport and message bounds #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9d1c330
Commented action, message, service typesupport and message bounds
ahcorde 62fdddc
Merge remote-tracking branch 'origin/master' into ahcorde/docblock/ro…
ahcorde 1f6add1
Added feedback
ahcorde d585e90
Comment string functions
ahcorde 0487a6f
Added feedback
ahcorde 5cdf0f4
Added feedback
ahcorde fe40059
Fixed wording
ahcorde File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -26,44 +26,115 @@ extern "C" | |||||
| #endif | ||||||
|
|
||||||
| /// Initialize a rosidl_runtime_c__String structure. | ||||||
| /* The contents of rosidl_runtime_c__String are initialized to a single null character ('\0'). | ||||||
| /* | ||||||
| * The contents of rosidl_runtime_c__String are initialized to a single null character ('\0'). | ||||||
| * The string initially has size 0 and capacity 1. | ||||||
| * Size represents the size of the contents of the string, while capacity represents the overall | ||||||
| * storage of the string (counting the null terminator). | ||||||
| * All strings must be null-terminated. | ||||||
| * The rosidl_runtime_c__String structure should be deallocated using the given function | ||||||
| * rosidl_runtime_c__String__fini() when it is no longer needed. | ||||||
| * Call this function with an already initialized string will leak memory. | ||||||
|
||||||
| * Call this function with an already initialized string will leak memory. | |
| * Calling this function with an already initialized string will leak memory. |
Fix here and below.
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed fe40059
ahcorde marked this conversation as resolved.
Show resolved
Hide resolved
ahcorde marked this conversation as resolved.
Show resolved
Hide resolved
ahcorde marked this conversation as resolved.
Show resolved
Hide resolved
ahcorde marked this conversation as resolved.
Show resolved
Hide resolved
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.