Skip to content

Support QoS options for ros2 service call #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fujitatomoya merged 2 commits into from
Feb 7, 2025
Merged

Support QoS options for ros2 service call #966

fujitatomoya merged 2 commits into from
Feb 7, 2025

Conversation

@fujitatomoya
Copy link
Collaborator

@fujitatomoya fujitatomoya commented Feb 1, 2025

part of #818, replaces #812 (out of date)

@fujitatomoya fujitatomoya mentioned this pull request Feb 1, 2025
Closed
fujitatomoya
fujitatomoya commented Feb 1, 2025
View reviewed changes
@fujitatomoya
Copy link
Collaborator Author

fujitatomoya commented Feb 1, 2025

@ahcorde can you take a look when you have time?

@fujitatomoya fujitatomoya requested a review from ahcorde February 1, 2025 05:10
@ahcorde
Copy link
Contributor

ahcorde commented Feb 7, 2025

Pulls: #966
Gist: https://gist.githubusercontent.com/ahcorde/04bae87aeceb98f0be849dfcf5196df1/raw/201438d25e520462ee37f9e60bab62909eaa00a3/ros2.repos
BUILD args: --packages-up-to ros2service --packages-above-and-dependencies ros2service
TEST args: --packages-select ros2service --packages-above ros2service
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15136

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

fujitatomoya commented Feb 7, 2025

Pulls: #966
Gist: https://gist.githubusercontent.com/fujitatomoya/4e91a72e81cff2dc574afbe3e551849d/raw/201438d25e520462ee37f9e60bab62909eaa00a3/ros2.repos
BUILD args: --packages-above-and-dependencies ros2service ros2topic
TEST args: --packages-above ros2service ros2topic
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15137

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

fujitatomoya commented Feb 7, 2025

@ahcorde thanks for doing review and starting CI.

just in case i added ros2topic for the CI.

bastianhjaeger
bastianhjaeger approved these changes Feb 7, 2025
View reviewed changes
Copy link

@bastianhjaeger bastianhjaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for solving this.

@fujitatomoya fujitatomoya merged commit 3332095 into rolling Feb 7, 2025
3 checks passed
@fujitatomoya fujitatomoya mentioned this pull request Feb 7, 2025
Open
@fujitatomoya fujitatomoya mentioned this pull request May 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

+1 more reviewer

@bastianhjaeger bastianhjaeger bastianhjaeger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fujitatomoya @ahcorde @bastianhjaeger