Restore asterisk under interface field types tables #5978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christophe Bedard <[email protected]>
christophebedard
added
the
backport-all
|
HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/18725369426/artifacts/4343471353. To view the resulting site:
|
Member
Author
|
@InvincibleRMC I noticed this while looking at this page for #5820. I think this sentence isn't very clear unless you've looked at the |
fujitatomoya
approved these changes
Oct 22, 2025
christophebedard
deleted the
christophebedard/about-interfaces-restore-asterisk
branch
mergify bot
pushed a commit
that referenced
this pull request
Oct 23, 2025
Signed-off-by: Christophe Bedard <[email protected]> (cherry picked from commit 8aeaf2a)
mergify bot
pushed a commit
that referenced
this pull request
Oct 23, 2025
Signed-off-by: Christophe Bedard <[email protected]> (cherry picked from commit 8aeaf2a)
mergify bot
pushed a commit
that referenced
this pull request
Oct 23, 2025
Signed-off-by: Christophe Bedard <[email protected]> (cherry picked from commit 8aeaf2a)
This was referenced Oct 23, 2025
christophebedard
added a commit
that referenced
this pull request
Oct 23, 2025
(cherry picked from commit 8aeaf2a) Signed-off-by: Christophe Bedard <[email protected]> Co-authored-by: Christophe Bedard <[email protected]>
christophebedard
added a commit
that referenced
this pull request
Oct 23, 2025
(cherry picked from commit 8aeaf2a) Signed-off-by: Christophe Bedard <[email protected]> Co-authored-by: Christophe Bedard <[email protected]>
christophebedard
added a commit
that referenced
this pull request
Oct 23, 2025
(cherry picked from commit 8aeaf2a) Signed-off-by: Christophe Bedard <[email protected]> Co-authored-by: Christophe Bedard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to #5820.
I noticed that there are asterisks in the field types tables (especially for Python types), but there's no corresponding note: https://docs.ros.org/en/rolling/Concepts/Basic/About-Interfaces.html#field-types.
I dug through the git history, and found that the note is the sentence below the 2nd table:
The asterisk was simply removed because it was not valid RST: 2aafc06. Restore it while making sure it's valid RST.
Did you use Generative AI?
Additional Information