Switch to 'let' under 'include' tags for launch frontends #5923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophebedard
added
the
backport-all
christophebedard
commented
Oct 6, 2025
| See example of ``push_ros_namespace`` tag for a workaround. | ||
| * ``arg`` tags nested in an ``include`` tag don't support conditionals (``if``, ``unless``) or the ``description`` attribute. | ||
| * ``arg`` tag nested in an ``include`` tag is now ``let``. | ||
| However, ``arg`` is still supported for now. |
Member
Author
There was a problem hiding this comment.
The original change (ros2/launch#848) was backported to Kilted/Jazzy/Humble, so arg is still supported under include alongside let, but we should still mention this change to people using older distros. If/once arg under include is deprecated, we can remove this line for distros going forward.
Signed-off-by: Christophe Bedard <[email protected]>
christophebedard
force-pushed
the
christophebedard/launch-xml-yaml-include-switch-from-arg-to-let
branch
from
c236206 to
94a37c5
Compare
|
HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/18296698859/artifacts/4198011490. To view the resulting site:
|
ahcorde
approved these changes
Oct 7, 2025
ahcorde
deleted the
christophebedard/launch-xml-yaml-include-switch-from-arg-to-let
branch
mergify bot
pushed a commit
that referenced
this pull request
Oct 7, 2025
Signed-off-by: Christophe Bedard <[email protected]> (cherry picked from commit 51e6598)
mergify bot
pushed a commit
that referenced
this pull request
Oct 7, 2025
Signed-off-by: Christophe Bedard <[email protected]> (cherry picked from commit 51e6598)
mergify bot
pushed a commit
that referenced
this pull request
Oct 7, 2025
Signed-off-by: Christophe Bedard <[email protected]> (cherry picked from commit 51e6598)
mergify bot
pushed a commit
that referenced
this pull request
Oct 7, 2025
Signed-off-by: Christophe Bedard <[email protected]> (cherry picked from commit 51e6598)
mergify bot
pushed a commit
that referenced
this pull request
Oct 7, 2025
Signed-off-by: Christophe Bedard <[email protected]> (cherry picked from commit 51e6598)
mergify bot
pushed a commit
that referenced
this pull request
Oct 7, 2025
Signed-off-by: Christophe Bedard <[email protected]> (cherry picked from commit 51e6598)
ahcorde
pushed a commit
that referenced
this pull request
Oct 7, 2025
) (cherry picked from commit 51e6598) Signed-off-by: Christophe Bedard <[email protected]> Co-authored-by: Christophe Bedard <[email protected]>
ahcorde
pushed a commit
that referenced
this pull request
Oct 7, 2025
) (cherry picked from commit 51e6598) Signed-off-by: Christophe Bedard <[email protected]> Co-authored-by: Christophe Bedard <[email protected]>
ahcorde
pushed a commit
that referenced
this pull request
Oct 7, 2025
) (cherry picked from commit 51e6598) Signed-off-by: Christophe Bedard <[email protected]> Co-authored-by: Christophe Bedard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This corresponds to changes in launch frontends: ros2/launch#848. This does not affect Python launch files.
This PR updates some launch XML/YAML examples to use
letunderincludetags.It also updates the migration guide: (1) migrating from ROS 1's
argand (2) newlettag in ROS 2.Did you use Generative AI?
Additional Information