-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Enable Zenoh router to make the post-install example work #5858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahcorde
approved these changes
Sep 16, 2025
ahcorde
requested changes
Sep 16, 2025
Contributor
ahcorde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/home/runner/work/ros2_documentation/ros2_documentation/source/Installation/RHEL-Install-RPMs.rst:128:'any' reference target not found: ZenohCo-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Luis Javier Arizmendi Alonso <[email protected]>
fujitatomoya
approved these changes
Sep 17, 2025
Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Luis Javier Arizmendi Alonso <[email protected]>
Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Luis Javier Arizmendi Alonso <[email protected]>
Collaborator
|
@ahcorde i will leave this to you, can you approve and merge? |
ahcorde
approved these changes
Sep 18, 2025
mergify bot
pushed a commit
that referenced
this pull request
Sep 18, 2025
Signed-off-by: Luis Javier Arizmendi Alonso <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> (cherry picked from commit b684b72)
mergify bot
pushed a commit
that referenced
this pull request
Sep 18, 2025
Signed-off-by: Luis Javier Arizmendi Alonso <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> (cherry picked from commit b684b72)
This was referenced Sep 18, 2025
mergify bot
pushed a commit
that referenced
this pull request
Sep 18, 2025
Signed-off-by: Luis Javier Arizmendi Alonso <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> (cherry picked from commit b684b72)
ahcorde
added a commit
that referenced
this pull request
Sep 18, 2025
) (cherry picked from commit b684b72) Signed-off-by: Luis Javier Arizmendi Alonso <[email protected]> Co-authored-by: Luis Javier Arizmendi Alonso <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]>
ahcorde
added a commit
that referenced
this pull request
Sep 18, 2025
) (cherry picked from commit b684b72) Signed-off-by: Luis Javier Arizmendi Alonso <[email protected]> Co-authored-by: Luis Javier Arizmendi Alonso <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]>
ahcorde
added a commit
that referenced
this pull request
Sep 18, 2025
) (cherry picked from commit b684b72) Signed-off-by: Luis Javier Arizmendi Alonso <[email protected]> Co-authored-by: Luis Javier Arizmendi Alonso <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]>
This was referenced Sep 18, 2025
Merged
This was referenced Oct 17, 2025
MrBearing
added a commit
to MrBearing/ros2_documentation
that referenced
this pull request
Oct 21, 2025
fujitatomoya
pushed a commit
to MrBearing/ros2_documentation
that referenced
this pull request
Oct 21, 2025
mergify bot
pushed a commit
that referenced
this pull request
Oct 21, 2025
* Revert "Enable Zenoh router to make the post-install example work (#5858)" This reverts commit b684b72. * Revert "Enable zenohd to make the post-install example work for Ubuntu Debian. (#5860)" This reverts commit 86d8c1a. * Added link to RMW implementations page. (cherry picked from commit ecc26c2)
mergify bot
pushed a commit
that referenced
this pull request
Oct 21, 2025
* Revert "Enable Zenoh router to make the post-install example work (#5858)" This reverts commit b684b72. * Revert "Enable zenohd to make the post-install example work for Ubuntu Debian. (#5860)" This reverts commit 86d8c1a. * Added link to RMW implementations page. (cherry picked from commit ecc26c2)
mergify bot
pushed a commit
that referenced
this pull request
Oct 21, 2025
* Revert "Enable Zenoh router to make the post-install example work (#5858)" This reverts commit b684b72. * Revert "Enable zenohd to make the post-install example work for Ubuntu Debian. (#5860)" This reverts commit 86d8c1a. * Added link to RMW implementations page. (cherry picked from commit ecc26c2) # Conflicts: # source/Installation/RHEL-Install-RPMs.rst # source/Installation/Ubuntu-Install-Debs.rst
fujitatomoya
pushed a commit
that referenced
this pull request
Oct 21, 2025
* Revert "Enable Zenoh router to make the post-install example work (#5858)" This reverts commit b684b72. * Revert "Enable zenohd to make the post-install example work for Ubuntu Debian. (#5860)" This reverts commit 86d8c1a. * Added link to RMW implementations page. (cherry picked from commit ecc26c2) Co-authored-by: Takumi Okamoto <[email protected]>
fujitatomoya
pushed a commit
that referenced
this pull request
Oct 21, 2025
* Revert "Enable Zenoh router to make the post-install example work (#5858)" This reverts commit b684b72. * Revert "Enable zenohd to make the post-install example work for Ubuntu Debian. (#5860)" This reverts commit 86d8c1a. * Added link to RMW implementations page. (cherry picked from commit ecc26c2) Co-authored-by: Takumi Okamoto <[email protected]>
fujitatomoya
added a commit
that referenced
this pull request
Oct 21, 2025
…) (#5977) * Fixing misleading Zenoh usage in try-some-example #5954 (#5957) * Revert "Enable Zenoh router to make the post-install example work (#5858)" This reverts commit b684b72. * Revert "Enable zenohd to make the post-install example work for Ubuntu Debian. (#5860)" This reverts commit 86d8c1a. * Added link to RMW implementations page. (cherry picked from commit ecc26c2) # Conflicts: # source/Installation/RHEL-Install-RPMs.rst # source/Installation/Ubuntu-Install-Debs.rst * resolve conflicts. Signed-off-by: Tomoya.Fujita <[email protected]> --------- Signed-off-by: Tomoya.Fujita <[email protected]> Co-authored-by: Takumi Okamoto <[email protected]> Co-authored-by: Tomoya.Fujita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you run the example as it appears in the DOC you won't get it working (listener do not receive anything).
Just by starting the Zenoh router it works:
ros2 run rmw_zenoh_cpp rmw_zenohdI only updated the RHEL documentation since it is the system where I faced and solved the issue, but probably it will also happen in Ubuntu.
Did you use Generative AI?
NO
Additional Information
If you run without the router enabled you will get these warnings in both talker and listener: