-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update Writing-a-Composable-Node.rst #5796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading the node into the component container fails as it builds a static library. Signed-off-by: Muhammad Awais <[email protected]>
fujitatomoya
approved these changes
Jul 19, 2025
christophebedard
approved these changes
Jul 19, 2025
| .. code-block:: cmake | ||
| add_library(vincent_driver_component src/vincent_driver.cpp) | ||
| add_library(vincent_driver_component SHARED src/vincent_driver.cpp) |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default depends on BUILD_SHARED_LIBS: https://cmake.org/cmake/help/v3.31/command/add_library.html#normal-libraries
If no
<type>is given the default isSTATICorSHAREDbased on the value of theBUILD_SHARED_LIBSvariable.
but it certainly makes sense to use SHARED here.
mergify bot
pushed a commit
that referenced
this pull request
Jul 19, 2025
Loading the node into the component container fails as it builds a static library. Signed-off-by: Muhammad Awais <[email protected]> (cherry picked from commit bb11078)
mergify bot
pushed a commit
that referenced
this pull request
Jul 19, 2025
Loading the node into the component container fails as it builds a static library. Signed-off-by: Muhammad Awais <[email protected]> (cherry picked from commit bb11078)
mergify bot
pushed a commit
that referenced
this pull request
Jul 19, 2025
Loading the node into the component container fails as it builds a static library. Signed-off-by: Muhammad Awais <[email protected]> (cherry picked from commit bb11078)
This was referenced Jul 19, 2025
christophebedard
pushed a commit
that referenced
this pull request
Jul 19, 2025
Loading the node into the component container fails as it builds a static library. (cherry picked from commit bb11078) Signed-off-by: Muhammad Awais <[email protected]> Co-authored-by: Muhammad Awais <[email protected]>
christophebedard
pushed a commit
that referenced
this pull request
Jul 19, 2025
Loading the node into the component container fails as it builds a static library. (cherry picked from commit bb11078) Signed-off-by: Muhammad Awais <[email protected]> Co-authored-by: Muhammad Awais <[email protected]>
christophebedard
pushed a commit
that referenced
this pull request
Jul 19, 2025
Loading the node into the component container fails as it builds a static library. (cherry picked from commit bb11078) Signed-off-by: Muhammad Awais <[email protected]> Co-authored-by: Muhammad Awais <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading the node into the component container fails as it builds a static library.
Description
Fixed documentation to build a shared library.
Fixes # (issue)
Failed to load component: Failed to load library: could not load library dlopen error: /home/mawais/repos/ros2_ws/install/ros_graph_viz/lib/libgraph_entities_component.a: invalid elf header, at ./src/shared_library.c:99
Did you use Generative AI?
No
Additional Information