Additional comment on callback group references (backport #5774) #5775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Goodall <[email protected]> (cherry picked from commit 36e260b)
|
HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/16261195835/artifacts/3524550326. To view the resulting site:
|
ahcorde
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have found that without keeping the shared pointer to a callback group, the callbacks in the group will never be called, leading to deadlocks.
Fixes # (issue)
Did you use Generative AI?
No
Additional Information
This is an automatic backport of pull request #5774 done by [Mergify](https://mergify.com).