Update launch_turtlesim_launch.py #5730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extra comma here causes the type of `launch_dir` to change, resulting in an error. Signed-off-by: today <[email protected]>
ahcorde
approved these changes
Jun 12, 2025
Contributor
|
https://github.com/Mergifyio backport kilted jazzy rolling |
Contributor
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 12, 2025
The extra comma here causes the type of `launch_dir` to change, resulting in an error. Signed-off-by: today <[email protected]> (cherry picked from commit 36dd34e)
mergify bot
pushed a commit
that referenced
this pull request
Jun 12, 2025
The extra comma here causes the type of `launch_dir` to change, resulting in an error. Signed-off-by: today <[email protected]> (cherry picked from commit 36dd34e)
mergify bot
pushed a commit
that referenced
this pull request
Jun 12, 2025
The extra comma here causes the type of `launch_dir` to change, resulting in an error. Signed-off-by: today <[email protected]> (cherry picked from commit 36dd34e)
ahcorde
pushed a commit
that referenced
this pull request
Jun 12, 2025
The extra comma here causes the type of `launch_dir` to change, resulting in an error. (cherry picked from commit 36dd34e) Signed-off-by: today <[email protected]> Co-authored-by: today <[email protected]>
ahcorde
pushed a commit
that referenced
this pull request
Jun 12, 2025
The extra comma here causes the type of `launch_dir` to change, resulting in an error. (cherry picked from commit 36dd34e) Signed-off-by: today <[email protected]> Co-authored-by: today <[email protected]>
ahcorde
pushed a commit
that referenced
this pull request
Jun 12, 2025
The extra comma here causes the type of `launch_dir` to change, resulting in an error. (cherry picked from commit 36dd34e) Signed-off-by: today <[email protected]> Co-authored-by: today <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extra comma here causes the type of
launch_dirto change, resulting in an error.Description
This PR fixes an issue where an extra comma in the definition of
launch_dircaused it to be interpreted as a tuple instead of the intendedPathJoinSubstitutionobject. This type mismatch led to aTypeErrorduring launch file parsing, as the ROS 2 framework expects a substitution object or string for path resolution.Key changes:
PathJoinSubstitutionassignment to ensurelaunch_dirremains a single object.Fixes #<issue_number> (replace with the actual issue number if available).
Did you use Generative AI?
No.
Additional Information
This change ensures the launch file adheres to Python syntax rules for variable assignment, maintaining the intended behavior of dynamically constructing file paths for ROS 2 components. The fix is minimal and targets the specific line identified in the error traceback, ensuring compatibility with existing workflows.