Review "Fast DDS Discovery Server" for Kilted #5544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahcorde
approved these changes
May 5, 2025
Contributor
Contributor
❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚. |
Contributor
Contributor
❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚. |
Contributor
|
https://github.com/Mergifyio backport kilted |
Contributor
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 5, 2025
(cherry picked from commit 582ec19)
4 tasks
ahcorde
pushed a commit
that referenced
this pull request
May 5, 2025
(cherry picked from commit 582ec19) Co-authored-by: danielcranston <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some small things that came up in ros2/kilted_tutorial_party#129.
Outstanding issues to be addressed before merging:
--remap __node:=listener, do we want to remove or keep?--no-daemonissue mentioned in Discovery Server kilted_tutorial_party#129 (comment)I'd appreciate comments on the above!