Skip to content

Complete publisher/subscription QoS query API test coverage. #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 7, 2020
Merged

Complete publisher/subscription QoS query API test coverage. #120

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adb2e7f
Complete publisher/subscription QoS query API test coverage.
hidmic Aug 20, 2020
3b32d71
Drop no allocation requirement from QoS query API tests.
hidmic Aug 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions test_rmw_implementation/test/test_publisher.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,13 @@ TEST_F(CLASSNAME(TestPublisherUse, RMW_IMPLEMENTATION), get_actual_qos_with_bad_
ret = rmw_publisher_get_actual_qos(pub, nullptr);
EXPECT_EQ(RMW_RET_INVALID_ARGUMENT, ret);
rmw_reset_error();

const char * implementation_identifier = pub->implementation_identifier;
pub->implementation_identifier = "not-an-rmw-implementation-identifier";
ret = rmw_publisher_get_actual_qos(pub, &actual_qos_profile);
pub->implementation_identifier = implementation_identifier;
EXPECT_EQ(RMW_RET_INCORRECT_RMW_IMPLEMENTATION, ret);
rmw_reset_error();
}

TEST_F(CLASSNAME(TestPublisherUse, RMW_IMPLEMENTATION), get_actual_qos) {
Expand Down