Add dependency on ament_cmake_gtest

[sloretz]

#106 (comment)

@hidmic FYI

[sloretz]

CI (building up to and testing only test_rmw_implementation)

• Linux
• Linux-aarch64
• macOS
• Windows

[dirk-thomas]

Shouldn't it be a test_depend instead?

[sloretz]

Shouldn't it be a test_depend instead?

I think either works. I picked buildtool_depend to match <buildtool_depend>rmw_implementation_cmake</buildtool_depend> which could also be a test_depend for the same reason.

[sloretz]

Shouldn't it be a test_depend instead?

Actually, it brings up an interesting case with the package.xml when cross-compiling. Does <test_depend> mean the dependency is needed on the target machine or the buildtool machine in order to run tests? Maybe there should be a <buildtool_test_depend> for dependencies needed only on the buildtool machine to run tests..

[sloretz]

Maybe there should be a <buildtool_test_depend> for dependencies needed only on the buildtool machine to run tests..

Ah nevermind, REP 149 already covers this:

When building with testing enabled, the <test_depend> packages are available for configuring and building the tests as well as running them. Generated Debian packages are built without the unit tests or their dependencies.

[sloretz]

Shouldn't it be a test_depend instead?

@dirk-thomas rmw_implementation_cmake and ament_cmake_gtest made test_depend in f7e0563

[sloretz]

CI (building and testing `test_rmw_implementation only)

• Linux only as I'll assume a package.xml only change won't fail on other platforms if it passes on Linux

[hidmic]

Uh, I thought I had added the dependency. Oh well, thanks for the fix @sloretz !!