Skip to content

Return specific error code when node is not found #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 17, 2019
Merged

Return specific error code when node is not found #311

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e729a9
Return specific error when node is not found
ivanpauno Aug 29, 2019
2c9808e
Stop logging error. Set better error message
ivanpauno Aug 30, 2019
e3e5ce2
Corrected errorgit add *
ivanpauno Aug 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions rmw_fastrtps_shared_cpp/src/rmw_node_info_and_types.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,12 @@ rmw_ret_t __get_guid_by_name(
});

if (guid_node_pair == impl->listener->discovered_names.end()) {
RCUTILS_LOG_ERROR_NAMED(
kLoggerTag,
"Unable to find GUID for node: %s", node_name);
RMW_SET_ERROR_MSG("Unable to find GUID for node ");
return RMW_RET_ERROR;
RMW_SET_ERROR_MSG_WITH_FORMAT_STRING(
"Node name not found: ns='%s', name='%s",
node_namespace,
node_name
);
return RMW_RET_NODE_NAME_NON_EXISTENT;
}
guid = guid_node_pair->first;
}
Expand Down