Compatibility before and after RMW pub/sub option structures #51
Conversation
Signed-off-by: Erik Boasson <[email protected]>
rotu
changed the title
Use CMake rmw_VERSION for conditional compilation Signed-off-by: Dan Rose <[email protected]>
rotu
force-pushed
the
mmw_version_rebase
branch
from
bac9852 to
6ef7d89
Compare
|
The functional changes look good to me. Leaving it up to someone else to merge. Why are the non-functional changes (line wrapping etc.) part of this PR? |
|
Looks good to me, too. Just verified it on current Eloquent on macOS as well as building against an old binary install of dashing. I'll merge if @dirk-thomas is happy with it too. Many thanks @rotu for helping out with the cyclone RMW and to @dirk-thomas for getting the RMW versioning in so quickly! |
I reformatted the code local to my changes to comply with the C++ developer guide. This should not be controversial; please don't bikeshed. |
The change itself is not controversial. I would just suggest to use a separate PR for unrelated changes - which I don't think is bikeshedding but a commonly agreed upon rational for making pull requests. Anyway - I am not maintaining this repo - so it is just an outsider comment. No need to do anything about it. |
3 participants
Includes changes in #46, in a way that makes it work both before and after ros2/rmw#187