Skip to content

Fix typesupport bug. #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix typesupport bug. #320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions rmw_cyclonedds_cpp/src/serdata.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,16 +51,17 @@ using ResponseTypeSupport_cpp = rmw_cyclonedds_cpp::ResponseTypeSupport<
rosidl_typesupport_introspection_cpp::ServiceMembers,
rosidl_typesupport_introspection_cpp::MessageMembers>;

static bool using_introspection_c_typesupport(const char * typesupport_identifier)
{
return typesupport_identifier == rosidl_typesupport_introspection_c__identifier;
static bool using_introspection_c_typesupport(const char* typesupport_identifier) {
return !std::string(typesupport_identifier)
Copy link
Member

@ivanpauno ivanpauno Jun 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use std::strcmp()?
To avoid allocating a std::string unnecessarely.

.compare(rosidl_typesupport_introspection_c__identifier);
}

static bool using_introspection_cpp_typesupport(const char * typesupport_identifier)
{
return typesupport_identifier == rosidl_typesupport_introspection_cpp::typesupport_identifier;
static bool using_introspection_cpp_typesupport(const char* typesupport_identifier) {
return !std::string(typesupport_identifier)
.compare(rosidl_typesupport_introspection_cpp::typesupport_identifier);
}


void * create_message_type_support(
const void * untyped_members,
const char * typesupport_identifier)
Expand Down