Skip to content

Remove domain_id and localhost_only from node API #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2020
Merged

Remove domain_id and localhost_only from node API #205

merged 1 commit into from
Jul 8, 2020

Conversation

@ivanpauno
Copy link
Member

@ivanpauno ivanpauno commented Jul 6, 2020

@ivanpauno ivanpauno added the enhancement New feature or request label Jul 6, 2020
@ivanpauno ivanpauno requested review from eboasson and hidmic July 6, 2020 21:39
@ivanpauno ivanpauno self-assigned this Jul 6, 2020
eboasson
eboasson approved these changes Jul 8, 2020
View reviewed changes
Copy link
Collaborator

@eboasson eboasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivanpauno ivanpauno merged commit d0d719a into master Jul 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/remove-domain-id-node-api branch July 8, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hidmic hidmic hidmic approved these changes

@eboasson eboasson eboasson approved these changes

Assignees

@ivanpauno ivanpauno

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ivanpauno @hidmic @eboasson