Exclude other RMW from Github CI build #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rotu
force-pushed
the
suppress_rmw
branch
2 times, most recently
from
705302c to
cd7e2f3
Compare
Since ros2#145, the CI build of rmw_cyclonedds_cpp has been failing on Windows due to inadvertently injecting fastrtps into the build process. fastrtps fails to build (eProsima/Fast-DDS#1173) causing the CI to fail. There doesn't seem to be a better way to suppress this in action-ros-ci ros-tooling/action-ros-ci#177 Fixes ros2#164
ivanpauno
approved these changes
Apr 29, 2020
Member
ivanpauno
left a comment
ivanpauno
left a comment
There was a problem hiding this comment.
LGTM!
It would be better if the actions have support for ignoring specific packages, but until then this does the job well.
ivanpauno
reviewed
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #145, the CI build of rmw_cyclonedds_cpp has been failing on Windows due to inadvertently injecting fastrtps into the build process.
fastrtps fails to build (eProsima/Fast-DDS#1173) causing the CI to fail.
There doesn't seem to be a better way to suppress this in action-ros-ci ros-tooling/action-ros-ci#177
Fixes #164