-
Notifications
You must be signed in to change notification settings - Fork 37
Handle 'best_available' QoS policies in common #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jose Luis Rivero <[email protected]>
|
I've added 7480115 following up the conversation in #84 (comment). That triggered some failures in the system test https://github.com/ros2/system_tests/pull/501/files <testcase name="test_best_available_policies_subscription" status="run" result="completed" time="0.313" timestamp="2022-04-28T16:52:18" classname="test_quality_of_service.QosRclcppTestFixture__rmw_connextdds">
<failure message="/home/jrivero/code/ros2/ws_qos_adaptative/src/ros2/system_tests/test_quality_of_service/test/test_best_available.cpp:76
Expected equality of these values:
 actual_qos.reliability()
 Which is: 4-b
Expected equality of these values:
actual_qos.reliability()
Which is: 4-byte object <01-00 00-00>
publisher_qos_profile.reliability()
Which is: 4-byte object <02-00 00-00>]]></failure>
<failure message="/home/jrivero/code/ros2/ws_qos_adaptative/src/ros2/system_tests/test_quality_of_service/test/test_best_available.cpp:78
Expected equality of these values:
 actual_qos.deadline()
 Which is: 16-byt
Expected equality of these values:
actual_qos.deadline()
Which is: 16-byte object <F8-34 5A-26 37-7F 00-00 FF-FF FF-FF FF-FF FF-7F>
publisher_qos_profile.deadline()
Which is: 16-byte object <F8-34 5A-26 37-7F 00-00 80-84 1E-00 00-00 00-00>]]></failure>
<failure message="/home/jrivero/code/ros2/ws_qos_adaptative/src/ros2/system_tests/test_quality_of_service/test/test_best_available.cpp:80
Expected equality of these values:
 actual_qos.liveliness_lease_duration()

Expected equality of these values:
actual_qos.liveliness_lease_duration()
Which is: 16-byte object <F8-34 5A-26 37-7F 00-00 FF-FF FF-FF FF-FF FF-7F>
publisher_qos_profile.liveliness_lease_duration()
Which is: 16-byte object <F8-34 5A-26 37-7F 00-00 C0-C6 2D-00 00-00 00-00>]]></failure>
</testcase> Am I missing a change in this PR or the changes are wrong? |
Co-authored-by: Jacob Perron <[email protected]>
Co-authored-by: Jacob Perron <[email protected]>
|
One more final change to make |
jacobperron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Jacob Perron <[email protected]>
Alternative to #84 after feedback received there.
I did not find problems on building or testing using this new approach. The PR looks cleaner.