Skip to content

Control shared/static linking via BUILD_SHARED_LIBS #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dirk-thomas merged 1 commit into from
Apr 5, 2017
Merged

Control shared/static linking via BUILD_SHARED_LIBS #81

dirk-thomas merged 1 commit into from
Apr 5, 2017
+3 −3

Conversation

@esteve
Copy link
Member

@esteve esteve commented Dec 8, 2016 •
edited
Loading

This PR delegates the decision to build a shared or a static library to CMake's BUILD_SHARED_LIBS

Update:

Connects to ros2/ros2#306

@esteve esteve added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Dec 8, 2016
This was referenced Dec 22, 2016
Closed
Closed
@dirk-thomas
Copy link
Member

dirk-thomas commented Apr 5, 2017 •
edited
Loading

This PR works as-is so I will go ahead and merge it (while some other related PRs are still pending). The Jenkins status looks worse as it is since the fork is older than the upstream master Update: that assumption was obviously wrong, see comment below:

  • Build Status
  • Build Status
  • Build Status

@dirk-thomas dirk-thomas merged commit be25abe into ros2:master Apr 5, 2017
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Apr 5, 2017
@dirk-thomas
Copy link
Member

dirk-thomas commented Apr 5, 2017

Thanks!

@dirk-thomas
Copy link
Member

dirk-thomas commented Apr 5, 2017

This change actually makes the gmock tests in rmw fail:

gmock_vendor/src/gmock_vendor/googlemock-1.7.0/include/gtest/gtest.h:2593:: pthread_key_delete(key_)failed with error 22

Looking into it...

@dirk-thomas dirk-thomas mentioned this pull request Apr 5, 2017
Merged
@dirk-thomas
Copy link
Member

dirk-thomas commented Apr 5, 2017

I reverted the merge since it actually fails on Windows and fails tests on Linus (even when using the default of shared libraries).

@dirk-thomas
Copy link
Member

dirk-thomas commented Apr 6, 2017

@esteve Can you please look into the problems and create a new PR which passes.

@dirk-thomas dirk-thomas mentioned this pull request Apr 7, 2017
Merged
@esteve esteve mentioned this pull request Apr 7, 2017
Merged
esteve added a commit to ament/gmock_vendor that referenced this pull request Apr 7, 2017
@esteve
Force static linking instead of honoring BUILD_SHARED_LIBS
b1d6e24 
Force static linking instead of honoring BUILD_SHARED_LIBS

See ros2/rmw#81 (comment)
@esteve esteve mentioned this pull request Apr 7, 2017
Merged
@esteve esteve deleted the honor-build-shared-libs branch April 7, 2017 13:04
@ros-discourse
Copy link

ros-discourse commented Jun 13, 2025

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/announcing-objective-c-on-macos-and-ios-for-ros2/946/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@esteve @dirk-thomas @ros-discourse