Add fault injection macros for use in other packages #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brawner
force-pushed
the
brawner/fault-injection-macros
branch
from
897314f to
1861408
Compare
brawner
force-pushed
the
brawner/fault-injection-macros
branch
from
1861408 to
8c51c9f
Compare
Contributor
Author
|
Testing this PR branch against current ros 2 branches (
|
This was referenced Aug 27, 2020
Blast545
reviewed
Aug 27, 2020
Blast545
left a comment
Blast545
left a comment
There was a problem hiding this comment.
Questions about API in general, might need a follow up PR or a separated discussion
| const char * str, | ||
| rcutils_allocator_t * allocator) | ||
| { | ||
| RCUTILS_CAN_RETURN_WITH_ERROR_OF(RMW_RET_INVALID_ARGUMENT); |
There was a problem hiding this comment.
Should this be able of returning BAD_ALLOC as well? I don't know why the output of rcutils_strdup is not checked there
There was a problem hiding this comment.
Same with the remaining part of the API receiving an allocator
Contributor
Author
There was a problem hiding this comment.
Opened #269 to add the new API and added a second RCUTILS_CAN_RETURN_WITH_ERROR_OF here.
brawner
force-pushed
the
brawner/fault-injection-macros
branch
from
8c51c9f to
09d4797
Compare
Contributor
Author
|
Rebased onto master after merging #269, retesting
|
Contributor
Author
|
Signed-off-by: Stephen Brawner <[email protected]>
Signed-off-by: Stephen Brawner <[email protected]>
Signed-off-by: Stephen Brawner <[email protected]>
Signed-off-by: Stephen Brawner <[email protected]>
brawner
force-pushed
the
brawner/fault-injection-macros
branch
from
724a377 to
3f8c2e4
Compare
Contributor
Author
|
A rebase did the trick |
ahcorde
pushed a commit
that referenced
this pull request
Oct 13, 2020
* Add fault injection macros for use in other packages Signed-off-by: Stephen Brawner <[email protected]> * cxx/c flags Signed-off-by: Stephen Brawner <[email protected]> * Address feedback Signed-off-by: Stephen Brawner <[email protected]> * lint cmake Signed-off-by: Stephen Brawner <[email protected]>
ahcorde
pushed a commit
that referenced
this pull request
Oct 13, 2020
* Add fault injection macros for use in other packages Signed-off-by: Stephen Brawner <[email protected]> * cxx/c flags Signed-off-by: Stephen Brawner <[email protected]> * Address feedback Signed-off-by: Stephen Brawner <[email protected]> * lint cmake Signed-off-by: Stephen Brawner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds fault injection macros for use in
rcl_actionandrcl_lifecycle.Signed-off-by: Stephen Brawner [email protected]