Deprecate get_env.h and move content to env.{h,c} #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christophe Bedard <[email protected]>
Signed-off-by: Christophe Bedard <[email protected]>
Signed-off-by: Christophe Bedard <[email protected]>
Signed-off-by: Christophe Bedard <[email protected]>
Signed-off-by: Christophe Bedard <[email protected]>
Signed-off-by: Christophe Bedard <[email protected]>
This was referenced Apr 30, 2021
clalancette
requested changes
May 2, 2021
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
A few minor things to fix up, but this is a good cleanup. Thanks!
This reverts commit 4eb6f85. Signed-off-by: Christophe Bedard <[email protected]>
Signed-off-by: Christophe Bedard <[email protected]>
clalancette
approved these changes
May 3, 2021
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
Looks good to me with green CI.
Member
Author
|
Should I do a CI run for this PR + the other related PRs all at once? |
Contributor
Yeah, that would be my suggestion. And in this case, since we are touching so many different packages, I'll just suggest doing one run where we build and test everything. |
Member
Author
Member
Author
|
Test failures on macOS look unrelated. |
Contributor
Yeah, agreed. Annoying, because it looks new, but not related to this PR. |
3 tasks
87 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves these
TODOs:rcutils/include/rcutils/env.h
Line 30 in ca42bc9
rcutils/src/env.c
Line 26 in ca42bc9
I think the intention was originally to deprecate in Galactic and remove in H-turtle (#250 (comment)), but it missed the ⛵ so it'll have to be deprecated in H-turtle and removed in I-turtle. I can create an issue for the removal after this is merged.