introduce rcutils_strcasecmp, case insensitive string compare. #280
Conversation
|
@iuhilnehc-ynos @Ada-King either of you, could you take a look at this? it seems that ros2/rcl#741 does not require this anymore, but i guess that this would be useful. |
iuhilnehc-ynos
left a comment
iuhilnehc-ynos
left a comment
There was a problem hiding this comment.
nitpick, just some minor comments.
fujitatomoya
force-pushed
the
feature-20200823-case-insensitive-cmp
branch
from
2f949db to
5a6a26c
Compare
|
comments are addressed, could you check when you got time? |
Signed-off-by: Tomoya.Fujita <[email protected]>
Signed-off-by: Tomoya.Fujita <[email protected]>
fujitatomoya
force-pushed
the
feature-20200823-case-insensitive-cmp
branch
from
66e0cb3 to
3a2e1d4
Compare
…than zero. Signed-off-by: Tomoya.Fujita <[email protected]>
|
@clalancette @iuhilnehc-ynos @Ada-King could you do review again? |
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
A couple more things to fix, then this will be ready to have CI.
Signed-off-by: Tomoya.Fujita <[email protected]>
|
thanks for the suggestion, i changed it back along with |
|
CI (only up to rcutils since this is a new API):
|
|
@fujitatomoya It looks like Windows has some warnings with this change. Can you look into it? Thanks. |
|
got it, i will address them in today. will get back to you. |
Signed-off-by: Tomoya.Fujita <[email protected]>
|
i believe windows is now comfortable with 9b586f2. Could you run CI again? thank! |
|
Thanks. Here's another CI run:
|
|
Looks good now, thanks for iterating @fujitatomoya ! |
4 participants
close #279
Signed-off-by: Tomoya.Fujita [email protected]