Skip to content

Avoid race condition in client.call() #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2021
Merged

Avoid race condition in client.call() #838

merged 1 commit into from
Oct 25, 2021

Conversation

@ivanpauno
Copy link
Member

@ivanpauno ivanpauno commented Oct 21, 2021

Fix the first of the two issues mentioned in #564.

@ivanpauno
Avoid race condition in client.call()
ae68fd5 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno ivanpauno added the bug Something isn't working label Oct 21, 2021
@ivanpauno ivanpauno requested a review from jacobperron October 21, 2021 19:20
@ivanpauno ivanpauno self-assigned this Oct 21, 2021
@ivanpauno
Copy link
Member Author

ivanpauno commented Oct 21, 2021

@jacobperron did this solve the issue for the case you mentioned here?

@ivanpauno ivanpauno mentioned this pull request Oct 21, 2021
Merged
fujitatomoya
fujitatomoya approved these changes Oct 21, 2021
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ivanpauno
Copy link
Member Author

ivanpauno commented Oct 22, 2021

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno ivanpauno merged commit dc46a36 into master Oct 25, 2021
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/avoid-race-client.call branch October 25, 2021 12:34
@ivanpauno ivanpauno mentioned this pull request Oct 25, 2021
Closed
jmarsik added a commit to km-robotics/rclpy that referenced this pull request May 12, 2022
@jmarsik
Avoid race condition in client.call() (ros2#838)
30e0875 
(cherry picked from commit dc46a36)
@augustelalande augustelalande mentioned this pull request Sep 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobperron jacobperron jacobperron approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

@ivanpauno ivanpauno

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ivanpauno @jacobperron @fujitatomoya