Skip to content

Replace rmw_connext_cpp with rmw_connextdds #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Replace rmw_connext_cpp with rmw_connextdds #698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions rclpy/test/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@
import rclpy
import rclpy.executors
from rclpy.impl.implementation_singleton import rclpy_implementation as _rclpy
from rclpy.utilities import get_rmw_implementation_identifier


# TODO(sloretz) Reduce fudge once wait_for_service uses node graph events
TIME_FUDGE = 0.3
Expand Down Expand Up @@ -92,10 +90,6 @@ def test_concurrent_calls_to_service(self):
self.node.destroy_client(cli)
self.node.destroy_service(srv)

# https://github.com/ros2/rmw_connext/issues/405
@unittest.skipIf(
get_rmw_implementation_identifier() == 'rmw_connext_cpp',
reason='Source timestamp not implemented for Connext')
def test_service_timestamps(self):
cli = self.node.create_client(GetParameters, 'get/parameters')
srv = self.node.create_service(
Expand Down
5 changes: 0 additions & 5 deletions rclpy/test/test_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
from rclpy.qos import QoSProfile
from rclpy.qos import QoSReliabilityPolicy
from rclpy.time_source import USE_SIM_TIME_NAME
from rclpy.utilities import get_rmw_implementation_identifier
from test_msgs.msg import BasicTypes

TEST_NODE = 'my_node'
Expand Down Expand Up @@ -145,10 +144,6 @@ def test_create_raw_subscription(self):
def dummy_cb(self, msg):
pass

# https://github.com/ros2/rmw_connext/issues/405
@unittest.skipIf(
get_rmw_implementation_identifier() == 'rmw_connext_cpp',
reason='Source timestamp not implemented for Connext')
def test_take(self):
basic_types_pub = self.node.create_publisher(BasicTypes, 'take_test', 1)
sub = self.node.create_subscription(
Expand Down