Enforce static parameter types when dynamic typing is not specified #683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Member
Author
|
CI to check if this breaks any downstream package:
|
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Member
Author
|
@jacobperron this is now ready for review |
Member
Author
|
@jacobperron friendly ping |
jacobperron
reviewed
Mar 1, 2021
Member
jacobperron
left a comment
jacobperron
left a comment
There was a problem hiding this comment.
Good stuff!
I've left a some minor suggestions and have a couple questions.
Signed-off-by: Ivan Santiago Paunovic <[email protected]> Co-authored-by: Jacob Perron <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Member
Author
|
CI:
|
jacobperron
approved these changes
Mar 2, 2021
delete-merged-branch
bot
deleted the
ivanpauno/enforce-parameter-types-rclpy
branch
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/feedback-required-should-parameters-be-able-to-change-of-type/18319/2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Equivalent to ros2/rclcpp#1522.