Added clients by node implementation from rcl #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 3, 2019 11:03
Signed-off-by: Siddharth Kucheria <[email protected]>
Signed-off-by: Siddharth Kucheria <[email protected]>
Signed-off-by: Siddharth Kucheria <[email protected]>
skucheria
force-pushed
the
kucheria/clients_by_node
branch
from
6b003cf to
b90941c
Compare
jacobperron
reviewed
Jul 8, 2019
Member
jacobperron
left a comment
jacobperron
left a comment
There was a problem hiding this comment.
Some minor comments. Also, add a smoke test for the new node method, similar to get_service_names_and_types.
Co-Authored-By: Jacob Perron <[email protected]>
Co-Authored-By: Jacob Perron <[email protected]>
jacobperron
approved these changes
Jul 8, 2019
Member
jacobperron
left a comment
jacobperron
left a comment
There was a problem hiding this comment.
Two small comments to address, otherwise LGTM with green CI 👍
Member
Author
|
Member
|
I believe this introduced a regression in our nightlies: I don't understand why, though because I don't see the trailing whitespace on line 182... |
Merged
Member
|
It's definitely there, but I don't know that this pr was the culprit: #385 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to ros2/sros2#141
Requires ros2/rcl#459