node_handle must be destroyed after client_handle to prevent memory leak #1562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoya.Fujita <[email protected]>
Collaborator
Author
|
@ivanpauno if you got time, could you take a look at this? thanks in advance. |
Collaborator
Author
|
CI:
|
ivanpauno
approved these changes
Feb 25, 2021
Collaborator
Author
|
the problem originally found in ros:foxy, backport is required. |
fujitatomoya
added a commit
to fujitatomoya/rclcpp
that referenced
this pull request
Feb 25, 2021
…eak (ros2#1562) Signed-off-by: Tomoya.Fujita <[email protected]>
fujitatomoya
added a commit
to fujitatomoya/rclcpp
that referenced
this pull request
Feb 25, 2021
…eak (ros2#1562) Signed-off-by: Tomoya Fujita <[email protected]>
fujitatomoya
added a commit
that referenced
this pull request
Feb 27, 2021
…eak (#1562) (#1565) Signed-off-by: Tomoya Fujita <[email protected]>
Karsten1987
pushed a commit
that referenced
this pull request
Mar 2, 2021
…eak (#1562) Signed-off-by: Tomoya.Fujita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address #1545
Signed-off-by: Tomoya.Fujita [email protected]