make rcl_lifecyle_com_interface optional in lifecycle nodes #1507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fujitatomoya
reviewed
Jan 7, 2021
Contributor
|
Same comment as ros2/rcl#882 (comment) |
fujitatomoya
requested changes
Feb 5, 2021
Karsten1987
force-pushed
the
optional_com_interface
branch
from
1063fb4 to
df8ba78
Compare
Collaborator
|
@ros-pull-request-builder retest this please |
Collaborator
|
@Karsten1987 there is DCO error, could you check that? |
Signed-off-by: Karsten Knese <[email protected]>
Co-authored-by: Tomoya Fujita <[email protected]>
Signed-off-by: Karsten Knese <[email protected]>
Karsten1987
force-pushed
the
optional_com_interface
branch
from
df8ba78 to
9c9b6e1
Compare
Signed-off-by: Karsten Knese <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connects to #1506