👨‍🌾 Regression in Rci benchmark in ParameterClientTest

[azeey]

Bug report

Required Info:

• Operating System:
  • Ubuntu 20.04
• Installation type:
  • source
• Version or commit hash:
  • 4e7c3e7c71d26a3203c431a65d6a69a5cf121d67
• DDS implementation:
  • Default
• Client library (if applicable):
  • rclcpp

The test suite ParameterClientTest in test/benchmark/benchmark_parameter_client started failing on build https://build.ros2.org/view/Rci/job/Rci__benchmark_ubuntu_focal_amd64/292/ most likely due to #1522. The relevant error messages are:

---------------------------------------------------------------------------------------------
Benchmark                                                   Time             CPU   Iterations
---------------------------------------------------------------------------------------------
ParameterClientTest/create_destroy_client             1346985 ns      1157423 ns          606
ParameterClientTest/has_parameter_hit                   76843 ns        26478 ns        27912
ParameterClientTest/has_parameter_miss                  75472 ns        24902 ns        29207
ParameterClientTest/set_parameters_bool            ERROR OCCURRED: 'Failed to set one or more parameters'
ParameterClientTest/set_parameters_atomically_bool ERROR OCCURRED: 'Failed to set parameters: Wrong parameter type, parameter {my_prefix.my_param_1} is of type {string}, setting it to {bool} is not allowed.'
ParameterClientTest/set_parameters_string          ERROR OCCURRED: 'Failed to set one or more parameters'
ParameterClientTest/set_parameters_array           ERROR OCCURRED: 'Failed to set one or more parameters'
ParameterClientTest/get_parameters                      76761 ns        26188 ns        26128
ParameterClientTest/list_parameters_hit                 76610 ns        26127 ns        26750
ParameterClientTest/list_parameters_miss                75200 ns        24642 ns        27541

---

https://github.com/osrf/buildfarmer/issues/161

[ivanpauno]

Ups, thanks for reporting this!!!