Added rcl_logging_spdlog tests #37
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <[email protected]>
Contributor
Author
|
Running CI up-to rcl_logging_spdlog to check the new test
|
Contributor
|
@ahcorde friendly ping, is this PR ready for review? |
Contributor
Author
|
Yes, this PR is open for review. I marked this as a Draft because of this other PR #36 |
Merged
Contributor
Member
|
I'd like to unify the approach for testing both of these implementations using a harness. Can we keep this open until I get that ready? |
Contributor
|
Is this one still viable, or do we have what we need from other PRs? |
Contributor
|
I'm going to go ahead and close this one out for now. Please feel free to reopen when we come back to addressing these tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spdlog will generate a log file inside
~/.ros/log. The idea of this test is to write some log messages using different log levels and then review the generated file and check that the messages are written properlySigned-off-by: ahcorde [email protected]