Skip to content

Remove unnecessary extern "C" #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Remove unnecessary extern "C" #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions rcl_logging_noop/src/rcl_logging_noop/rcl_logging_noop.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@

#include <rcutils/allocator.h>

extern "C" {

typedef int rcl_logging_ret_t;
#define RCL_LOGGING_RET_OK (0)

Expand Down Expand Up @@ -46,5 +44,3 @@ rcl_logging_ret_t rcl_logging_external_set_logger_level(const char * name, int l
(void) level;
return RCL_LOGGING_RET_OK;
}

} /* extern "C" */
8 changes: 0 additions & 8 deletions rcl_logging_spdlog/src/rcl_logging_spdlog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,6 @@
#define RCL_LOGGING_RET_OK (0)
#define RCL_LOGGING_RET_ERROR (2)

#ifdef __cplusplus
extern "C" {
#endif

static std::mutex g_logger_mutex;
static std::unique_ptr<spdlog::logger> g_root_logger = nullptr;

Expand Down Expand Up @@ -174,7 +170,3 @@ rcl_logging_ret_t rcl_logging_external_set_logger_level(const char * name, int l

return RCL_LOGGING_RET_OK;
}

#ifdef __cplusplus
} /* extern "C" */
#endif