Check if the value of the timer pointer is null and exchange by signed int64 #972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoyZuberi
force-pushed
the
bugfix/fix-rcl-period-arguments
branch
from
5fde311 to
63df4e5
Compare
Collaborator
|
address #971 |
NoyZuberi
force-pushed
the
bugfix/fix-rcl-period-arguments
branch
3 times, most recently
from
317c564 to
7b4a4a0
Compare
…d int64 Signed-off-by: Noy <[email protected]>
NoyZuberi
force-pushed
the
bugfix/fix-rcl-period-arguments
branch
from
7b4a4a0 to
cb0e910
Compare
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
@NoyZuberi appreciate for your contribution. but we try to fix bugs against master branch and then we can backport the fix for each distribution. would you create PR against master branch? thanks!
| atomic_uintptr_t callback; | ||
| // This is a duration in nanoseconds. | ||
| atomic_uint_least64_t period; | ||
| atomic_int_least64_t period; |
Collaborator
There was a problem hiding this comment.
I think you are addressing #967 on this PR too, but probably it would be nice to open different PR for this. and i think #967 (comment) makes more sense to me.
Comment on lines
+236
to
+239
| if (timer->impl == NULL) { | ||
| RCL_SET_ERROR_MSG("timer is invalid"); | ||
| return RCL_RET_INVALID_ARGUMENT; | ||
| } |
Collaborator
There was a problem hiding this comment.
how about the following? so are other places.
Suggested change
| if (timer->impl == NULL) { | |
| RCL_SET_ERROR_MSG("timer is invalid"); | |
| return RCL_RET_INVALID_ARGUMENT; | |
| } | |
| RCL_CHECK_ARGUMENT_FOR_NULL(timer->impl, RCL_RET_INVALID_ARGUMENT); |
Collaborator
|
I will go ahead to close this in favor of #973 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.