Skip to content

Add const to constant rcl_context functions #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2020
Merged

Add const to constant rcl_context functions #872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f41377c
Add const keyword in function signature of rcl_context_get_instance_id
ThijsRay Dec 3, 2020
8d173bc
Add const keyword in function signature of rcl_context_is_valid
ThijsRay Dec 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rcl/include/rcl/context.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ rcl_context_get_init_options(const rcl_context_t * context);
RCL_PUBLIC
RCL_WARN_UNUSED
rcl_context_instance_id_t
rcl_context_get_instance_id(rcl_context_t * context);
rcl_context_get_instance_id(const rcl_context_t * context);

/// Returns the context domain id.
/**
Expand Down Expand Up @@ -287,7 +287,7 @@ rcl_context_get_domain_id(rcl_context_t * context, size_t * domain_id);
RCL_PUBLIC
RCL_WARN_UNUSED
bool
rcl_context_is_valid(rcl_context_t * context);
rcl_context_is_valid(const rcl_context_t * context);

/// Return pointer to the rmw context if the given context is currently valid, otherwise `NULL`.
/**
Expand Down
4 changes: 2 additions & 2 deletions rcl/src/rcl/context.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ rcl_context_get_init_options(const rcl_context_t * context)
}

rcl_context_instance_id_t
rcl_context_get_instance_id(rcl_context_t * context)
rcl_context_get_instance_id(const rcl_context_t * context)
{
RCL_CHECK_ARGUMENT_FOR_NULL(context, 0);
return rcutils_atomic_load_uint64_t((atomic_uint_least64_t *)(&context->instance_id_storage));
Expand All @@ -91,7 +91,7 @@ rcl_context_get_domain_id(rcl_context_t * context, size_t * domain_id)
}

bool
rcl_context_is_valid(rcl_context_t * context)
rcl_context_is_valid(const rcl_context_t * context)
{
RCL_CHECK_ARGUMENT_FOR_NULL(context, false);
return 0 != rcl_context_get_instance_id(context);
Expand Down