[Foxy backport] Use valid clock in case of issue in rcl_timer_init (#795) Store reference to rcl_clock_t instead of copy (#797) #805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use valid clock in case of issue Signed-off-by: Stephen Brawner <[email protected]> * Cleanup Signed-off-by: Stephen Brawner <[email protected]> Signed-off-by: Shane Loretz <[email protected]>
rcl_clock_t can't be trivially copied because adding or removing clock jump callbacks to a copy will free the pointer held by the original instance. Signed-off-by: Shane Loretz<[email protected]> Signed-off-by: Shane Loretz <[email protected]>
jacobperron
approved these changes
Sep 18, 2020
Member
jacobperron
left a comment
jacobperron
left a comment
There was a problem hiding this comment.
LGTM.
It'd be nice to get the CI job to turn green before merging. Looks like an infrastructure issue?
Contributor
Author
|
@ros-pull-request-builder retest this please |
1 similar comment
Member
|
@ros-pull-request-builder retest this please |
Contributor
Author
|
Looks like PR job is happy and PR is approved. I'll merge with just the PR job since it's a cherry-pick backport. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #795 and #797 to Foxy