Skip to content

Add bad arguments tests for coverage #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Blast545 merged 16 commits into from
Jul 3, 2020
Merged

Add bad arguments tests for coverage #698

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
3bd84f7
Add test context bad_fini
Blast545 Jun 22, 2020
4618d67
Replace bad allocator file
Blast545 Jun 22, 2020
273b548
Rever allocator change
Blast545 Jun 22, 2020
93ea835
Add bad name service tests
Blast545 Jun 22, 2020
c08a293
Add default case validation result
Blast545 Jun 22, 2020
d932eca
Add bad_arg tests rcl_lexer_lookahead2_accept
Blast545 Jun 23, 2020
e91a0fd
Add bad_arg test rcl_trigger_guard_condition
Blast545 Jun 23, 2020
51551ee
Add bad arguments events test
Blast545 Jun 23, 2020
06239c5
Add message_lost event test
Blast545 Jun 24, 2020
33479c5
Disable failing test
Blast545 Jun 24, 2020
639a17d
Address peer review comments
Blast545 Jun 24, 2020
766d5a0
Remove failing test
Blast545 Jul 1, 2020
b0453b2
Separate non related API tests
Blast545 Jul 1, 2020
ac4d561
Add comments to explain error causes
Blast545 Jul 1, 2020
8f364e0
Use test fixture without params
Blast545 Jul 2, 2020
b3885a1
Replace nullptr with NULL
Blast545 Jul 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion rcl/test/rcl/test_events.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,7 +709,6 @@ TEST_P(TestEventFixture, test_sub_message_lost_event)
ASSERT_EQ(ret, RCL_RET_OK) << rcl_get_error_string().str;

// Check if supported
// Returns -11 for rmw_cyclonedds_cpp
subscription_event = rcl_get_zero_initialized_event();
ret = rcl_subscription_event_init(
&subscription_event,
Expand All @@ -726,6 +725,10 @@ TEST_P(TestEventFixture, test_sub_message_lost_event)
return;
}

// (TODO blast545): Enable the rest of the test, timeout failing
Comment thread
Blast545 marked this conversation as resolved.
Outdated
// conditional_wait_for_msgs_and_events returns Timeout for rmw_cyclonedds_cpp
return;

WaitConditionPredicate events_ready = [](
const bool & /*msg_persist_ready*/,
const bool & subscription_persist_ready,
Expand Down
16 changes: 11 additions & 5 deletions rcl/test/rcl/test_guard_condition.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,11 +127,6 @@ TEST_F(
gc_handle = rcl_guard_condition_get_rmw_handle(&guard_condition);
});
EXPECT_NE(nullptr, gc_handle);
// Test failed rcl_trigger_guard_condition
EXPECT_EQ(RCL_RET_INVALID_ARGUMENT, rcl_trigger_guard_condition(nullptr));
rcl_reset_error();
EXPECT_EQ(RCL_RET_INVALID_ARGUMENT, rcl_trigger_guard_condition(&zero_guard_condition));
rcl_reset_error();
}

/* Tests the guard condition life cycle, including rcl_guard_condition_init/fini().
Expand Down Expand Up @@ -221,3 +216,14 @@ TEST_F(
EXPECT_EQ(RCL_RET_OK, ret);
rcl_reset_error();
}

/* Tests trigger_guard_condition with bad arguments
*/
TEST_F(
CLASSNAME(TestGuardConditionFixture, RMW_IMPLEMENTATION), test_rcl_guard_condition_bad_arg) {
rcl_guard_condition_t zero_guard_condition = rcl_get_zero_initialized_guard_condition();
EXPECT_EQ(RCL_RET_INVALID_ARGUMENT, rcl_trigger_guard_condition(nullptr));
rcl_reset_error();
EXPECT_EQ(RCL_RET_INVALID_ARGUMENT, rcl_trigger_guard_condition(&zero_guard_condition));
rcl_reset_error();
}
2 changes: 1 addition & 1 deletion rcl/test/rcl/test_service.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ TEST_F(CLASSNAME(TestServiceFixture, RMW_IMPLEMENTATION), test_service_fail_name
EXPECT_EQ(RCL_RET_SERVICE_NAME_INVALID, ret) << rcl_get_error_string().str;
rcl_reset_error();

const char * topic2 = "{doesnotexist}";
const char * topic2 = "{invalidbecausecurlybraces}";
ret = rcl_service_init(&service, this->node_ptr, ts, topic2, &service_options);
EXPECT_EQ(RCL_RET_SERVICE_NAME_INVALID, ret) << rcl_get_error_string().str;
rcl_reset_error();
Expand Down