Replaced tinydir with rcutils #605
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <[email protected]>
3 tasks
mjcarroll
requested changes
Mar 27, 2020
Member
mjcarroll
left a comment
mjcarroll
left a comment
There was a problem hiding this comment.
Question about the pragmas.
Signed-off-by: ahcorde <[email protected]>
mjcarroll
approved these changes
Mar 27, 2020
Member
mjcarroll
left a comment
mjcarroll
left a comment
There was a problem hiding this comment.
LGTM with CI covering this + rcutils
Member
|
I'll defer to @mjcarroll if that's ok. |
dirk-thomas
reviewed
Mar 27, 2020
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
dirk-thomas
reviewed
Mar 30, 2020
Signed-off-by: ahcorde <[email protected]>
dirk-thomas
approved these changes
Mar 31, 2020
Member
|
Note: #515 already removes the tinydir dependency completely. This PR will likely conflict with that other one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ros2/rcutils#218 include some utils in rcutils to replace tinydir
wait for this PR to merge ros2/rcutils#218
Signed-off-by: ahcorde [email protected]