rebase of rcl rcl_node_get_fully_qualified_name implementation #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobperron
approved these changes
Feb 1, 2019
mjcarroll
added a commit
that referenced
this pull request
Mar 18, 2019
Regression was introduced in 114bc52 (PR #381). Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
added a commit
that referenced
this pull request
Mar 18, 2019
* Fix regression around fully qualified node name. Regression was introduced in 114bc52 (PR #381). Signed-off-by: Michael Carroll <[email protected]> * Clean up test code based on feedback. Signed-off-by: Michael Carroll <[email protected]> * Combine tests to prevent Connext timeout. Signed-off-by: Michael Carroll <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #255
This is a rebase of #369 from @rarvolt which is missing some of the recent refactorings. Without these changes it was failing CI.