Skip to content

Add clients servers info #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: rolling
Choose a base branch
from
Open

Add clients servers info #1161

wants to merge 3 commits into from

Conversation

@leeminju531
Copy link
Contributor

@leeminju531 leeminju531 commented Jun 25, 2024

Add get clients, servers info

Refer to ros2/ros2cli#916

@leeminju531 leeminju531 mentioned this pull request Jun 25, 2024
Open
@leeminju531
Copy link
Contributor Author

leeminju531 commented Jun 25, 2024

Dependencies
rmw
rmw_implementation
rmw_fastrtps
rmw_cyclonedds
rmw_connextdds

This was referenced Jun 25, 2024
Open
Open
fujitatomoya
fujitatomoya reviewed Jul 4, 2024
View reviewed changes
rcl/test/rcl/test_graph.cpp Outdated
rcl_reset_error();
}

/* Test the rcl_wait_for_clients function.
Copy link
Collaborator

@fujitatomoya fujitatomoya Jul 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/* Test the rcl_wait_for_clients function.
/* Test the rcl_wait_for_services function.

@leeminju531 leeminju531 force-pushed the add-clients-servers-info branch from f0957db to 03fd83d Compare June 22, 2025 02:30
ahcorde
ahcorde requested changes Jun 23, 2025
View reviewed changes
@ahcorde ahcorde mentioned this pull request Jul 21, 2025
Open
@ahcorde
Copy link
Contributor

ahcorde commented Jul 21, 2025

Pulls: ros2/rmw#371, ros2/rmw_implementation#238, #1161, ros2/rclcpp#2569, ros2/rclpy#1307, ros2/rmw_zenoh#679, ros2/rmw_fastrtps#771, ros2/rmw_cyclonedds#499, ros2/rmw_connextdds#154, ros2/ros2cli#916
Gist: https://gist.githubusercontent.com/ahcorde/302c3652a6220b1c87e62745e9f9afff/raw/742f65fffc9bfec58f851df6062324b9d1a85a3c/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rmw_implementation rcl rclcpp rclpy ros2cli ros2service
TEST args: --packages-above rmw rmw_implementation rcl rclcpp rclpy ros2cli ros2service
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16548

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

This was referenced Jul 21, 2025
Open
Open
Open
Open
Open
fujitatomoya
fujitatomoya reviewed Nov 6, 2025
View reviewed changes
rcl/src/rcl/graph.c


rcl_ret_t
rcl_wait_for_clients(
Copy link
Collaborator

@fujitatomoya fujitatomoya Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are not exactly related to the service info verbose feature, but nice to have, and actually used in the test.

@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Nov 6, 2025

@leeminju531 sorry for coming back on this late, we need to resolve the conflict on this repo. could you address it?

@fujitatomoya fujitatomoya force-pushed the add-clients-servers-info branch from 21da260 to 4f7ee86 Compare November 6, 2025 10:16
@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Nov 6, 2025

@leeminju531 i just went ahead to fix the conflict on my own, can you take a look at the latest fix by me just in case?

@fujitatomoya fujitatomoya requested a review from ahcorde November 6, 2025 10:18
fujitatomoya
fujitatomoya reviewed Nov 6, 2025
View reviewed changes
@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Nov 6, 2025

Pulls: ros2/ros2cli#916, ros2/rmw#371, ros2/rmw_implementation#238, ros2/rmw_fastrtps#771, ros2/rmw_cyclonedds#499, ros2/rmw_connextdds#154, #1161, ros2/rclcpp#2569, ros2/rclpy#1307, ros2/rmw_dds_common#82, ros2/rmw_zenoh#679
Gist: https://gist.githubusercontent.com/fujitatomoya/01385d70469b48f205a68e21219fd395/raw/b02c84fd17938124e2b045dbf016f260e6209ae0/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_zenoh_cpp rmw_dds_common rclpy rclcpp_lifecycle rclcpp rcl rmw_connextdds rmw_connextdds_common rmw_connextddsmicro rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_sharedcpp ros2cli ros2service rmw rmw_implementation test_rmw_implementation
TEST args: --packages-above rmw_zenoh_cpp rmw_dds_common rclpy rclcpp_lifecycle rclcpp rcl rmw_connextdds rmw_connextdds_common rmw_connextddsmicro rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_sharedcpp ros2cli ros2service rmw rmw_implementation test_rmw_implementation
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17407

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya mentioned this pull request Nov 6, 2025
Open
@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Nov 6, 2025

Pulls: ros2/ros2cli#916, ros2/rmw#371, ros2/rmw_implementation#238, ros2/rmw_fastrtps#771, ros2/rmw_cyclonedds#499, ros2/rmw_connextdds#154, #1161, ros2/rclcpp#2569, ros2/rclpy#1307, ros2/rmw_dds_common#82, ros2/rmw_zenoh#679
Gist: https://gist.githubusercontent.com/fujitatomoya/3c50929d3b3e884ba6796f6c9f26e92e/raw/b02c84fd17938124e2b045dbf016f260e6209ae0/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_zenoh_cpp rmw_dds_common rclpy rclcpp_lifecycle rclcpp rcl rmw_connextdds rmw_connextdds_common rmw_connextddsmicro rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp ros2cli ros2service rmw rmw_implementation test_rmw_implementation
TEST args: --packages-above rmw_zenoh_cpp rmw_dds_common rclpy rclcpp_lifecycle rclcpp rcl rmw_connextdds rmw_connextdds_common rmw_connextddsmicro rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp ros2cli ros2service rmw rmw_implementation test_rmw_implementation
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17408

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@audrow audrow Awaiting requested review from audrow

@ivanpauno ivanpauno Awaiting requested review from ivanpauno

@wjwwood wjwwood Awaiting requested review from wjwwood

Assignees

@fujitatomoya fujitatomoya

Labels

requires-changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@leeminju531 @ahcorde @fujitatomoya @cottsay