Re-order rcl_logging_interface include #1133
Merged
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christophe Bedard <[email protected]>
christophebedard
requested review from
audrow,
ivanpauno and
wjwwood
as code owners
clalancette
approved these changes
Feb 29, 2024
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
OK by me, though as you say we don't truly have a defined style here.
Contributor
|
Given that this is just updating the style, I'm going to go ahead and merge with the Rpr job passing green. |
christophebedard
deleted the
christophebedard/reorder-rcl-logging-interface-include
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're not very strict about includes, but I noticed a slight divergence as a result of #676