👩‍🌾 Various graph test failures on Windows release

[chapulina]

Many of these failures showed up at the same time during last night's Windows release build, so I'm ticketing them together. Let me know if it would be best to open separate issues for each of them.

test_graph__rmw_connext_cpp

Seems to have been flaky for a while, but got worse recently (failed 3/4 latest builds):

https://ci.ros2.org/view/nightly/job/nightly_win_rel/1741/testReport/projectroot/test/test_graph__rmw_connext_cpp/history/

Failure:

[ RUN      ] NodeGraphMultiNodeFixture.test_node_info_clients
C:\ci\ws\src\ros2\rcl\rcl\test\rcl\test_graph.cpp(966): error: Expected: (attempts) <= (max_attempts), actual: 5 vs 4
Unable to attain all required nodes
[  FAILED  ] NodeGraphMultiNodeFixture.test_node_info_clients (14453 ms)

rcl.NodeGraphMultiNodeFixture.test_node_info_clients

It may be a new failure, only failed in the latest build:

https://ci.ros2.org/view/nightly/job/nightly_win_rel/1741/testReport/rcl/NodeGraphMultiNodeFixture/test_node_info_clients/history/

Failure:

C:\ci\ws\src\ros2\rcl\rcl\test\rcl\test_graph.cpp:966
Expected: (attempts) <= (max_attempts), actual: 5 vs 4
Unable to attain all required nodes

rcl_action.TestActionGraphMultiNodeFixture.test_action_get_names_and_types

It's been very flaky for a while (failed 5/24 latest builds):

https://ci.ros2.org/view/nightly/job/nightly_win_rel/1741/testReport/rcl_action/TestActionGraphMultiNodeFixture/test_action_get_names_and_types/history/

Failure:

C:\ci\ws\src\ros2\rcl\rcl_action\test\rcl_action\test_graph.cpp:360
Expected: (attempts) <= (max_attempts), actual: 5 vs 4
Unable to attain all required nodes

rcl_action.TestActionGraphMultiNodeFixture.test_action_get_client_names_and_types_by_node

Very flaky, failed last 6/24 builds:

https://ci.ros2.org/view/nightly/job/nightly_win_rel/1741/testReport/rcl_action/TestActionGraphMultiNodeFixture/test_action_get_client_names_and_types_by_node/history/

Failure:

C:\ci\ws\src\ros2\rcl\rcl_action\test\rcl_action\test_graph.cpp:360
Expected: (attempts) <= (max_attempts), actual: 5 vs 4
Unable to attain all required nodes

rcl_action.TestActionGraphMultiNodeFixture.rcl_get_server_names_and_types_by_node_maybe_fail

Slightly flaky, failed 2/24 latest builds:

https://ci.ros2.org/view/nightly/job/nightly_win_rel/1741/testReport/rcl_action/TestActionGraphMultiNodeFixture/rcl_get_server_names_and_types_by_node_maybe_fail/history/

Failure:

C:\ci\ws\src\ros2\rcl\rcl_action\test\rcl_action\test_graph.cpp:360
Expected: (attempts) <= (max_attempts), actual: 5 vs 4
Unable to attain all required nodes

[ivanpauno]

#854 should have fixed this 🤞