Skip to content

Update goal response callback signature #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacobperron merged 1 commit into from
Sep 21, 2020
Merged

Update goal response callback signature #291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions rclcpp/actions/minimal_action_client/member_functions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,8 @@ class MinimalActionClient : public rclcpp::Node
rclcpp::TimerBase::SharedPtr timer_;
bool goal_done_;

void goal_response_callback(std::shared_future<GoalHandleFibonacci::SharedPtr> future)
void goal_response_callback(GoalHandleFibonacci::SharedPtr goal_handle)
{
auto goal_handle = future.get();
if (!goal_handle) {
RCLCPP_ERROR(this->get_logger(), "Goal was rejected by server");
} else {
Expand Down