Clarify remapping order for __node and __ns #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloretz
reviewed
Jul 17, 2018
articles/141_static_remapping.md
Outdated
| - A node has name `talker` | ||
| - A user remaps the node name to foo `talker:__node:=foo` | ||
| - A user remaps the original node's namespace `talker:__ns:=/my_namespace` | ||
| - The namespace is NOT changed because node name remaps are applied BEFORE namespace remaps |
Contributor
There was a problem hiding this comment.
I recommend phrasing to say what happens rather than what doesn't happen: The final namespace is /ns because the node name was remapped before the namespace
articles/141_static_remapping.md
Outdated
|
|
||
| - A node has name `talker` | ||
| - A user remaps the node name to foo `talker:__node:=foo` | ||
| - A user remaps the original node's namespace `talker:__ns:=/my_namespace` |
Contributor
There was a problem hiding this comment.
The example should show that __node happens first even if the rule is given second. How about combining the two bullets to show the order?
a user gives the rules `talker:__ns:=/my_namespace' then `__node:=foo`.
sloretz
added
in review
sloretz
approved these changes
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this comment. The design doc for remapping left the order of __node and __ns ambiguous, but RCL applied them in a specific order.