Skip to content

Push mimick.h into mimick/ directory. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2020
Merged

Push mimick.h into mimick/ directory. #7

merged 1 commit into from
Jul 30, 2020

Conversation

@hidmic
Copy link

@hidmic hidmic commented Jul 29, 2020

To avoid cpplint warnings in particular and to not treat mimick a standard library in a general.

@hidmic hidmic requested a review from Blast545 July 29, 2020 21:00
@hidmic hidmic mentioned this pull request Jul 29, 2020
Merged
Blast545
Blast545 approved these changes Jul 29, 2020
View reviewed changes
Copy link

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hidmic hidmic mentioned this pull request Jul 29, 2020
Merged
@hidmic hidmic merged commit 3176529 into ros2 Jul 30, 2020
@delete-merged-branch delete-merged-branch bot deleted the hidmic/relocate-mimick-header branch July 30, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Blast545 Blast545 Blast545 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hidmic @Blast545